Messages in this thread | | | Date | Mon, 5 Feb 2024 11:12:09 -1000 | From | Tejun Heo <> | Subject | Re: [PATCHSET wq/for-6.9] workqueue: Implement BH workqueue and convert several tasklet users |
| |
Hello, Allen.
On Mon, Feb 05, 2024 at 12:50:28PM -0800, Allen wrote: > Thank you. I am basing my work on the branch you have > pushed.(or-6.9-bh-conversions) > https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git/log/?h=for-6.9-bh-conversions > > In the order of priority, I have started converting drivers/media/*, > drivers/dma/* followed by drivers/net/* > which constitutes the majority. Putting my plan out here so that the > work is not duplicated. > I will write back in a day and share the branch for review.
That's great. Thanks.
> W.r.t the conversion, there are drivers which call > tasklet_[disable/enable](), which I suppose > can be ignored in the case of workqueues, I am not entirely sure if > this is the right approach. > Please correct me if I am wrong.
I don't think we can ignore them. I was just looking at tasklet_kill() and thought we're good because that seemed to map well to cancel_work_sync(). workqueue doesn't have the counterpart for tasklet_[disable/enable](). I'll look through them and think on it.
Thanks.
-- tejun
| |