Messages in this thread Patch in this message | | | Date | Mon, 5 Feb 2024 16:09:32 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 5/5] perf thread_map: Free strlist on normal path in thread_map__new_by_tid_str() |
| |
On Mon, Feb 05, 2024 at 10:46:16AM +0000, Yang Jihong wrote: > slist needs to be freed in both error path and normal path in > thread_map__new_by_tid_str().
Please add:
Fixes: b52956c961be3a04 ("perf tools: Allow multiple threads or processes in record, stat, top")
Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
- Arnaldo > Signed-off-by: Yang Jihong <yangjihong1@huawei.com> > --- > tools/perf/util/thread_map.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/thread_map.c b/tools/perf/util/thread_map.c > index e848579e61a8..ea3b431b9783 100644 > --- a/tools/perf/util/thread_map.c > +++ b/tools/perf/util/thread_map.c > @@ -280,13 +280,13 @@ struct perf_thread_map *thread_map__new_by_tid_str(const char *tid_str) > threads->nr = ntasks; > } > out: > + strlist__delete(slist); > if (threads) > refcount_set(&threads->refcnt, 1); > return threads; > > out_free_threads: > zfree(&threads); > - strlist__delete(slist); > goto out; > } > > -- > 2.34.1
| |