Messages in this thread | | | Date | Mon, 5 Feb 2024 10:15:25 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH v3 1/3] iommu/iova: Tidy up iova_cache_get() failure |
| |
On Mon, 5 Feb 2024, Robin Murphy wrote:
> Failure handling in iova_cache_get() is a little messy, and we'd like > to add some more to it, so let's tidy up a bit first. By leaving the > hotplug handler until last we can take advantage of kmem_cache_destroy() > being NULL-safe to have a single cleanup label. We can also improve the > error reporting, noting that kmem_cache_create() already screams if it > fails, so that one is redundant. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Much easier to follow :)
Acked-by: David Rientjes <rientjes@google.com>
| |