Messages in this thread | | | From | Vaibhav Jain <> | Subject | Re: [PATCH v2] KVM: PPC: Book3S HV: Fix L2 guest reboot failure due to empty 'arch_compat' | Date | Mon, 05 Feb 2024 23:05:23 +0530 |
| |
Hi Amit,
Thanks for the patch. Minor comment on the patch below:
Amit Machhiwal <amachhiw@linux.ibm.com> writes:
<snip>
> > +static inline unsigned long map_pcr_to_cap(unsigned long pcr) > +{ > + unsigned long cap = 0; > + > + switch (pcr) { > + case PCR_ARCH_300: > + cap = H_GUEST_CAP_POWER9; > + break; > + case PCR_ARCH_31: > + cap = H_GUEST_CAP_POWER10; Though CONFIG_CC_IMPLICIT_FALLTHROUGH and '-Wimplicit-fallthrough' doesnt explicitly flag this usage, please consider using the 'fallthrough;' keyword here.
However you probably dont want this switch-case to fallthrough so please use a 'break' instead.
> + default: > + break; > + } > + > + return cap; > +} > + > <snip>
With the suggested change above
Reviewed-by: Vaibhav Jain <vaibhav@linux.ibm.com>
-- Cheers ~ Vaibhav
| |