Messages in this thread | | | Date | Tue, 27 Feb 2024 08:00:18 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH] mm: export folio_pte_batch as a couple of modules might need it |
| |
On Tue, Feb 27, 2024 at 03:40:50PM +1300, Barry Song wrote: > From: Barry Song <v-songbaohua@oppo.com> > > madvise and some others might need folio_pte_batch to check if a range > of PTEs are completely mapped to a large folio with contiguous physcial > addresses. Let's export it for others to use.
It doesn't look exported to me in the patch (and that's a good thing!).
But even for making it non-static you probably want to include that in the series actually making use of it.
> +extern int folio_pte_batch(struct folio *folio, unsigned long addr, > + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > + bool *any_writable);
no need for the extern here.
| |