lkml.org 
[lkml]   [2024]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/3] platform/x86: wmi: Remove obsolete duplicate GUID allowlist
On Mon, 26 Feb 2024, Armin Wolf wrote:

> The whitelist-based approach for preventing older WMI drivers from
> being instantiated multiple times has many drawbacks:
>
> - uses cannot see all available WMI devices (if not whitelisted)
> - whitelisting a WMI driver requires changes in the WMI driver core
> - maintenance burden for driver and subsystem developers
>
> Since the WMI driver core already takes care that older WMI drivers
> are not being instantiated multiple times, remove the now redundant
> whitelist.
>
> Tested on a ASUS Prime B650-Plus.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> drivers/platform/x86/wmi.c | 39 --------------------------------------
> 1 file changed, 39 deletions(-)
>
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 349deced87e8..1920e115da89 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -90,16 +90,6 @@ static const struct acpi_device_id wmi_device_ids[] = {
> };
> MODULE_DEVICE_TABLE(acpi, wmi_device_ids);
>
> -/* allow duplicate GUIDs as these device drivers use struct wmi_driver */
> -static const char * const allow_duplicates[] = {
> - "05901221-D566-11D1-B2F0-00A0C9062910", /* wmi-bmof */
> - "8A42EA14-4F2A-FD45-6422-0087F7A7E608", /* dell-wmi-ddv */
> - "44FADEB1-B204-40F2-8581-394BBDC1B651", /* intel-wmi-sbl-fw-update */
> - "86CCFD48-205E-4A77-9C48-2021CBEDE341", /* intel-wmi-thunderbolt */
> - "F1DDEE52-063C-4784-A11E-8A06684B9B01", /* dell-smm-hwmon */
> - NULL
> -};

Great work, thank you.

I've applied the series to review-ilpo.

--
i.


\
 
 \ /
  Last update: 2024-05-27 15:24    [W:1.586 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site