lkml.org 
[lkml]   [2024]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hwrng: hisi - use dev_err_probe
On Mon, 26 Feb 2024 19:57:00 +0100
Martin Kaiser <martin@kaiser.cx> wrote:

> Replace dev_err + return with dev_err_probe.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Maybe worth wrapping the line in this subsystem still strives for
<= 80 chars


> ---
> drivers/char/hw_random/hisi-rng.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
> index b6f27566e0ba..4e501d5c121f 100644
> --- a/drivers/char/hw_random/hisi-rng.c
> +++ b/drivers/char/hw_random/hisi-rng.c
> @@ -89,10 +89,8 @@ static int hisi_rng_probe(struct platform_device *pdev)
> rng->rng.read = hisi_rng_read;
>
> ret = devm_hwrng_register(&pdev->dev, &rng->rng);
> - if (ret) {
> - dev_err(&pdev->dev, "failed to register hwrng\n");
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "failed to register hwrng\n");


















>
> return 0;
> }


\
 
 \ /
  Last update: 2024-05-27 15:24    [W:0.043 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site