Messages in this thread | | | Date | Tue, 27 Feb 2024 15:09:51 +0530 | Subject | Re: [PATCH] arm64/hw_breakpoint: Determine lengths from generic perf breakpoint macros | From | Anshuman Khandual <> |
| |
On 2/27/24 14:35, Will Deacon wrote: > On Tue, Feb 27, 2024 at 11:01:54AM +0530, Anshuman Khandual wrote: >> On 2/26/24 16:34, Mark Rutland wrote: >>> I don't think this needs to change, and can be left as-is. >> >> Fair enough, but just wondering how about deriving len_in_bytes from >> hweight_long(ARM_BREAKPOINT_LEN_*) instead ? This also drops the hard >> coding using the platform macros itself, without going to user ABI. > > Please leave this code alone. It's fine like it is and there are plenty of > other things that would actually benefit from your attention. The BRBE > series, for example.
Sure, no problem, will drop this patch.
| |