lkml.org 
[lkml]   [2024]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 08/18] ASoC: mediatek: mt8365: Add DMIC DAI support
    From
    On 26/02/2024 15:01, Alexandre Mergnat wrote:
    > Add Digital Micro Device Audio Interface support for MT8365 SoC.
    >
    > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>


    > +
    > +static int init_dmic_priv_data(struct mtk_base_afe *afe)
    > +{
    > + struct mt8365_afe_private *afe_priv = afe->platform_priv;
    > + struct mt8365_dmic_data *dmic_priv;
    > + struct device_node *np = afe->dev->of_node;
    > + unsigned int temps[4];
    > + int ret;
    > +
    > + dmic_priv = devm_kzalloc(afe->dev, sizeof(struct mt8365_dmic_data),
    > + GFP_KERNEL);

    You have very inconsistent style of coding. Some patches are done
    correctly, some repeast known issues. All over. This is sizeof(*). This
    comment (and all others) apply everywhere, just in case.

    Best regards,
    Krzysztof


    \
     
     \ /
      Last update: 2024-05-27 15:24    [W:4.667 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site