Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 27 Feb 2024 09:45:01 +0100 | Subject | Re: [PATCH 1/4] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions |
| |
Hi Arnd,
On Mon, Feb 26, 2024 at 5:14 PM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > These four architectures define the same Kconfig symbols for configuring > the page size. Move the logic into a common place where it can be shared > with all other architectures. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for your patch!
> --- a/arch/Kconfig > +++ b/arch/Kconfig
> +config PAGE_SIZE_4KB > + bool "4KB pages"
Now you got rid of the 4000-byte ("4kB") pages and friends, please do not replace these by Kelvin-bytes, and use the official binary prefixes => "4 KiB".
> + depends on HAVE_PAGE_SIZE_4KB
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |