lkml.org 
[lkml]   [2024]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] net: stmmac: dwmac-qcom-ethqos: Update link clock rate only for RGMII
> >   static void
> > ethqos_update_link_clk(struct qcom_ethqos *ethqos, unsigned int speed)
> > {
> > - switch (speed) {
> > - case SPEED_1000:
> > - ethqos->link_clk_rate = RGMII_1000_NOM_CLK_FREQ;
> > - break;
> > + if (phy_interface_mode_is_rgmii(ethqos->phy_mode)) {
> > + switch (speed) {
> > + case SPEED_1000:
> > + ethqos->link_clk_rate = RGMII_1000_NOM_CLK_FREQ;
> > + break;
> > - case SPEED_100:
> > - ethqos->link_clk_rate = RGMII_ID_MODE_100_LOW_SVS_CLK_FREQ;
> > - break;
> > + case SPEED_100:
> > + ethqos->link_clk_rate = RGMII_ID_MODE_100_LOW_SVS_CLK_FREQ;
> > + break;
> > - case SPEED_10:
> > - ethqos->link_clk_rate = RGMII_ID_MODE_10_LOW_SVS_CLK_FREQ;
> > - break;
> > - }
> > + case SPEED_10:
> > + ethqos->link_clk_rate = RGMII_ID_MODE_10_LOW_SVS_CLK_FREQ;
> > + break;
> > + }
> > - clk_set_rate(ethqos->link_clk, ethqos->link_clk_rate);
> > + clk_set_rate(ethqos->link_clk, ethqos->link_clk_rate);
> > + }
> > }
>
> if (!phy_interface_mode_is_rgmii(ethqos->phy_mode))
> return 0;

It is a void function, so no 0, but otherwise this does look less
invasive.

Andrew

\
 
 \ /
  Last update: 2024-05-27 15:22    [W:0.043 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site