Messages in this thread | | | Date | Tue, 27 Feb 2024 11:46:02 +1300 | Subject | Re: [PATCH v9 10/15] x86/sgx: Add EPC reclamation in cgroup try_charge() | From | "Huang, Kai" <> |
| |
On 27/02/2024 11:38 am, Dave Hansen wrote: > On 2/26/24 14:34, Huang, Kai wrote: >> So I am trying to get the actual downside of doing per-cgroup reclaim or >> the full reason that we choose global reclaim. > > Take the most extreme example: > > while (hit_global_sgx_limit()) > reclaim_from_this(cgroup); > > You eventually end up with all of 'cgroup's pages gone and handed out to > other users on the system who stole them all. Other users might cause > you to go over the global limit. *They* should be paying part of the > cost, not just you and your cgroup.
Yeah likely we will need another layer of logic to decide when to do global reclaim. I agree that is downside and is unnecessary for this patchset.
Thanks for the comments.
| |