lkml.org 
[lkml]   [2024]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 13/13] xfs: enable block size larger than page size support
On Mon, Feb 26, 2024 at 01:26:30PM +0000, Matthew Wilcox wrote:
> On Mon, Feb 26, 2024 at 10:49:36AM +0100, Pankaj Raghav (Samsung) wrote:
> > @@ -1625,16 +1625,10 @@ xfs_fs_fill_super(
> > goto out_free_sb;
> > }
> >
> > - /*
> > - * Until this is fixed only page-sized or smaller data blocks work.
> > - */
> > if (mp->m_sb.sb_blocksize > PAGE_SIZE) {
> > xfs_warn(mp,
> > - "File system with blocksize %d bytes. "
> > - "Only pagesize (%ld) or less will currently work.",
> > - mp->m_sb.sb_blocksize, PAGE_SIZE);
> > - error = -ENOSYS;
> > - goto out_free_sb;
> > +"EXPERIMENTAL: Filesystem with Large Block Size (%d bytes) enabled.",
> > + mp->m_sb.sb_blocksize);
>
> WARN seems a little high for this. xfs_notice() or xfs_info() would
> seem more appropriate:

Nope, warning level is correct and consistent with what we've used
for these experimental warnings.

xfs_warn(mp, "DAX enabled. Warning: EXPERIMENTAL, use at your own risk");

i.e. A message that says "Expect things not to work correctly in
your filesystem" is definitely worth warning level meddaging.

-Dave.
--
Dave Chinner
david@fromorbit.com

\
 
 \ /
  Last update: 2024-05-27 15:22    [W:0.052 / U:1.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site