lkml.org 
[lkml]   [2024]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 3/7] PCI: qcom: Add ICC bandwidth vote for CPU to PCIe path
From


On 2/24/2024 5:32 AM, Konrad Dybcio wrote:
> On 23.02.2024 15:48, Krishna chaitanya chundru wrote:
>> To access PCIe registers, PCIe BAR space, config space the CPU-PCIe
>> ICC(interconnect consumers) path should be voted otherwise it may
>> lead to NoC(Network on chip) timeout. We are surviving because of
>> other driver vote for this path.
>> As there is less access on this path compared to PCIe to mem path
>> add minimum vote i.e 1KBps bandwidth always.
>>
>> In suspend remove the disable this path after register space access
>> is done.
>>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>> ---
>
> [...]
>
>>
>> + /* Remove cpu path vote after all the register access is done */
>> + ret = icc_disable(pcie->icc_cpu);
>> + if (ret) {
>> + dev_err(dev, "failed to disable icc path of cpu-pcie: %d\n", ret);
>> + if (pcie->suspended) {
>> + qcom_pcie_host_init(&pcie->pci->pp);
>> + pcie->suspended = false;
>> + }
>> + qcom_pcie_icc_opp_update(pcie);
>
> This doesn't compile (you rename it in patch 6, this is patch 3)
>
> Konrad
>
I will fix this in my next series.

- Krishna Chaitanya.

\
 
 \ /
  Last update: 2024-05-27 15:24    [W:0.116 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site