lkml.org 
[lkml]   [2024]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v7 01/36] drm/tests: helpers: Include missing drm_drv header
    From
    On 2/22/24 15:13, Maxime Ripard wrote:
    > We have a few functions declared in our kunit helpers header, some of
    > them dereferencing the struct drm_driver.
    >
    > However, we don't include the drm_drv.h header file defining that
    > structure, leading to compilation errors if we don't include both
    > headers.
    >
    > Fixes: d98780310719 ("drm/tests: helpers: Allow to pass a custom drm_driver")
    > Signed-off-by: Maxime Ripard <mripard@kernel.org>

    Reviewed-by: Maíra Canal <mcanal@igalia.com>

    Best Regards,
    - Maíra

    > ---
    > include/drm/drm_kunit_helpers.h | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/include/drm/drm_kunit_helpers.h b/include/drm/drm_kunit_helpers.h
    > index ba483c87f0e7..3ae19892229d 100644
    > --- a/include/drm/drm_kunit_helpers.h
    > +++ b/include/drm/drm_kunit_helpers.h
    > @@ -3,6 +3,8 @@
    > #ifndef DRM_KUNIT_HELPERS_H_
    > #define DRM_KUNIT_HELPERS_H_
    >
    > +#include <drm/drm_drv.h>
    > +
    > #include <linux/device.h>
    >
    > #include <kunit/test.h>
    >

    \
     
     \ /
      Last update: 2024-05-27 15:21    [W:7.314 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site