Messages in this thread | | | Date | Mon, 26 Feb 2024 08:56:15 +0100 | Subject | Re: [PATCH net-next v5 6/7] net: hisilicon: add support for hisi_femac core on Hi3798MV200 | From | Krzysztof Kozlowski <> |
| |
On 23/02/2024 14:28, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > Register the sub MDIO bus if it is found. Also implement the internal > PHY reset procedure as needed. > > Note it's unable to put the MDIO bus node outside of MAC controller > (i.e. at the same level in the parent bus node). Because we need to > control all clocks and resets in FEMAC driver due to the phy reset > procedure. So the clocks can't be assigned to MDIO bus device, which is > an essential resource for the MDIO bus to work. > > No backward compatibility is maintained since the only existing > user(Hi3516DV300) has not received any updates from HiSilicon for about > 8 years already. And till today, no mainline dts for this SoC is found. > It seems unlikely that there are still existing mainline Hi3516DV300 > users. The effort to maintain the old binding seems gain a little. > > Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
NAK, implement comments from v4.
Best regards, Krzysztof
| |