Messages in this thread | | | Date | Mon, 26 Feb 2024 15:09:38 +0900 | From | Masami Hiramatsu (Google) <> | Subject | Re: [PATCH v2] selftests/ftrace: Limit length in subsystem-enable tests |
| |
On Mon, 26 Feb 2024 11:18:16 +0800 Yuanhe Shu <xiangzao@linux.alibaba.com> wrote:
> While sched* events being traced and sched* events continuously happen, > "[xx] event tracing - enable/disable with subsystem level files" would > not stop as on some slower systems it seems to take forever. > Select the first 100 lines of output would be enough to judge whether > there are more than 3 types of sched events.
Looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Hi Shuah, can you pick this as a fix?
Thank you,
> > Fixes: 815b18ea66d6 ("ftracetest: Add basic event tracing test cases") > Cc: stable@vger.kernel.org > Signed-off-by: Yuanhe Shu <xiangzao@linux.alibaba.com> > --- > .../selftests/ftrace/test.d/event/subsystem-enable.tc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > index b1ede6249866..b7c8f29c09a9 100644 > --- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > +++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > @@ -18,7 +18,7 @@ echo 'sched:*' > set_event > > yield > > -count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l` > +count=`head -n 100 trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l` > if [ $count -lt 3 ]; then > fail "at least fork, exec and exit events should be recorded" > fi > @@ -29,7 +29,7 @@ echo 1 > events/sched/enable > > yield > > -count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l` > +count=`head -n 100 trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l` > if [ $count -lt 3 ]; then > fail "at least fork, exec and exit events should be recorded" > fi > @@ -40,7 +40,7 @@ echo 0 > events/sched/enable > > yield > > -count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l` > +count=`head -n 100 trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l` > if [ $count -ne 0 ]; then > fail "any of scheduler events should not be recorded" > fi > -- > 2.39.3 > >
-- Masami Hiramatsu (Google) <mhiramat@kernel.org>
| |