Messages in this thread | | | Date | Mon, 26 Feb 2024 06:32:39 +0100 | Subject | Re: [PATCH 3/4] kfifo: add kfifo_out_linear{,_ptr}() | From | Jiri Slaby <> |
| |
On 24. 02. 24, 3:31, Andrew Morton wrote: > On Fri, 23 Feb 2024 12:51:54 +0100 "Jiri Slaby (SUSE)" <jirislaby@kernel.org> wrote: > >> + return min(n, __kfifo_peek_n(fifo, recsize); > > When things like this happen I wonder "was I sent the correct version" > and "was this tested" and "wtf". > > Please confirm that with this patch: > > --- a/lib/kfifo.c~a > +++ a/lib/kfifo.c > @@ -497,7 +497,7 @@ unsigned int __kfifo_out_linear_r(struct > if (tail) > *tail = fifo->out + recsize; > > - return min(n, __kfifo_peek_n(fifo, recsize); > + return min(n, __kfifo_peek_n(fifo, recsize)); > } > EXPORT_SYMBOL(__kfifo_out_linear_r); > > @@ -609,4 +609,3 @@ unsigned int __kfifo_dma_out_prepare_r(s > return setup_sgl(fifo, sgl, nents, len, fifo->out + recsize); > } > EXPORT_SYMBOL(__kfifo_dma_out_prepare_r); > > we have a fully tested, production quality kernel change?
After Friday's last minute changes, there are apparently more issues (as reported by the test robot). Please drop this series, I will send a better one.
And I understand that you are OK for this to go through serial, so I will post with the serial "users" too. Of course with you in Cc, so that you can (N)Ack.
thanks and sorry for the bogus submission, -- js suse labs
| |