lkml.org 
[lkml]   [2024]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next 03/10] net/tcp: Move tcp_inbound_hash() from headers
On Mon, Feb 26, 2024 at 8:43 PM Simon Horman <horms@kernel.org> wrote:
>
> On Sat, Feb 24, 2024 at 09:04:11AM +0000, Dmitry Safonov wrote:
[..]
> > + if (req) {
> > + if (tcp_rsk_used_ao(req) != !!aoh) {
> > + u8 keyid, rnext, maclen;
> > +
> > + if (aoh) {
> > + keyid = aoh->keyid;
> > + rnext = aoh->rnext_keyid;
> > + maclen = tcp_ao_hdr_maclen(aoh);
> > + } else {
> > + keyid = rnext = maclen = 0;
> > + }
>
> Hi Dmitry,
>
> it looks like keyid is set but otherwise unused.
>
> Flagged by W=1 builds with gcc-13 and clang-17.

Hi Simon,

Yeah, I think I didn't notice it when I was splitting the WIP patch.
It should be in the very next patch that uses them:
+ trace_tcp_ao_handshake_failure(sk, skb, keyid,
rnext, maclen);

Thanks for the report, going to fix in v2,
Dmitry

\
 
 \ /
  Last update: 2024-05-27 15:24    [W:0.073 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site