Messages in this thread | | | Date | Mon, 26 Feb 2024 15:08:42 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH 1/1] dt-bindings: pci: layerscape-pci: Convert to yaml format |
| |
On Mon, Feb 26, 2024 at 02:57:11PM -0500, Frank Li wrote: > Convert the layerscape-pci PCIe binding document to yaml format. > > Additionally, changes for the layerscape-pci endpoint part: > - Add interrupt name 'pme' restriction for fsl,ls1028a-pcie-ep, > fsl,ls1046a-pcie-ep, and fsl,ls1088a-pcie-ep. > - Add register name restrictions: 'reg' and 'addr_space'. 'addr_space' is > required by snps,dw-pcie-ep. > - Add an example.
Not for me to say since this would go via some other tree, but in general, I would prefer to see this as two or three patches:
1) Strict conversion to yaml with no additional changes 2) Add new layerscape-ep stuff 3) Add new layerscape root complex stuff
That makes it easier to see what is actually being added.
> Changes for the layerscape-pci root complex part: > - Add required property: 'reg-names', "#address-cells", "#size-cells", > 'device_type', 'bus-range', 'ranges', "#interrupt-cells", > 'interrupt-map-mask' and 'interrupt-map'. > - Interrupt-names requirement split to each compatible string. > - Add register name restrictions: 'reg' and 'config'. 'config' is required > by snps,dw-pcie.
| |