Messages in this thread | | | Date | Mon, 26 Feb 2024 15:04:32 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v7 2/5] PCI/ASPM: Always build aspm.c |
| |
On Sun, Feb 25, 2024 at 10:44:14PM -0800, Kuppuswamy Sathyanarayanan wrote: > On 2/23/24 12:58 PM, Bjorn Helgaas wrote: > > From: "David E. Box" <david.e.box@linux.intel.com> > > > > Some ASPM-related tasks, such as save and restore of LTR and L1SS > > capabilities, still need to be performed when CONFIG_PCIEASPM is not > > enabled. To prepare for these changes, wrap the current code in aspm.c > > with an #ifdef and always build the file. > > Since save/restore needs to be called even if CONFIG_PCIEASPM is > not set, why not just leave it in pci.c?
We could do that, but we're accumulating various bits of ASPM-related suspend/resume functionality (LTR, L1SS, etc) that seem like they fit better in aspm.c.
Bjorn
| |