Messages in this thread | | | Date | Mon, 26 Feb 2024 19:59:28 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v6 5/8] net: phy: Immediately call adjust_link if only tx_lpi_enabled changes |
| |
On Mon, Feb 26, 2024 at 05:53:31PM +0000, Russell King (Oracle) wrote: > On Mon, Feb 26, 2024 at 09:50:02AM -0800, Florian Fainelli wrote: > > This is the source of the concern, we don't know which MAC drivers we might > > end-up breaking by calling adjust_link(link == 1) twice in a row, hopefully > > none, because they should be well written to only update the parameters that > > need updating, but who knows? > > Just quickly... There are some (I went through a bunch.) They don't > support EEE. I haven't been through all though, so there could be > some which support EEE and where adjust_link() with phydev->link=true > twice in a row could result in badness.
So i think we all agree the MAC needs to see a down/up, even if the link itself never went down. Anything else is too risky and will probably break something somewhere.
Andrew
| |