Messages in this thread Patch in this message | | | From | Thomas Gleixner <> | Subject | Re: [tip: x86/apic] smp: Provide 'setup_max_cpus' definition on UP too | Date | Mon, 26 Feb 2024 19:19:29 +0100 |
| |
On Mon, Feb 26 2024 at 11:48, tip-bot2 for Ingo Molnar wrote: > --- a/include/linux/smp.h > +++ b/include/linux/smp.h > @@ -218,6 +218,8 @@ smp_call_function_any(const struct cpumask *mask, smp_call_func_t func, > static inline void kick_all_cpus_sync(void) { } > static inline void wake_up_all_idle_cpus(void) { } > > +static const unsigned int setup_max_cpus = 0;
Oops. I missed that when looking at the patch. This is in a header file and will be instantiated a gazillion times where ever the header is included. It want's to be a define, no?
Thanks,
tglx --- --- a/include/linux/smp.h +++ b/include/linux/smp.h @@ -218,7 +218,7 @@ smp_call_function_any(const struct cpuma static inline void kick_all_cpus_sync(void) { } static inline void wake_up_all_idle_cpus(void) { } -static const unsigned int setup_max_cpus = 0; +#define setup_max_cpus (0) #ifdef CONFIG_UP_LATE_INIT extern void __init up_late_init(void);
| |