Messages in this thread | | | Date | Mon, 26 Feb 2024 12:20:41 -0500 | From | Frank Li <> | Subject | Re: [PATCH v8 09/10] PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event |
| |
On Sat, Feb 24, 2024 at 12:24:15PM +0530, Manivannan Sadhasivam wrote: > Now that the API is available, let's make use of it. It also handles the > reinitialization of DWC non-sticky registers in addition to sending the > notification to EPF drivers. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > index 2fb8c15e7a91..4e45bc4bca45 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > @@ -640,7 +640,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data) > if (FIELD_GET(PARF_INT_ALL_LINK_DOWN, status)) { > dev_dbg(dev, "Received Linkdown event\n"); > pcie_ep->link_status = QCOM_PCIE_EP_LINK_DOWN; > - pci_epc_linkdown(pci->ep.epc); > + dw_pcie_ep_linkdown(&pci->ep);
Suppose pci_epc_linkdown() will call dw_pcie_ep_linkdown() ? why need direct call dw_pcie_ep_linkdown() here?
Frank
> } else if (FIELD_GET(PARF_INT_ALL_BME, status)) { > dev_dbg(dev, "Received BME event. Link is enabled!\n"); > pcie_ep->link_status = QCOM_PCIE_EP_LINK_ENABLED; > > -- > 2.25.1 >
| |