Messages in this thread | | | Date | Mon, 26 Feb 2024 16:48:51 +0100 | From | Marco Pagani <> | Subject | Re: [PATCH] drm/test/shmem: set a DMA mask for the mock device |
| |
On 2024-02-26 12:26, Maxime Ripard wrote: > Hi, > > On Mon, Feb 26, 2024 at 12:00:27PM +0100, Marco Pagani wrote: >> Set a DMA mask for the mock device to avoid warnings generated in >> dma_map_sgtable(). >> >> Reported-by: Guenter Roeck <linux@roeck-us.net> >> Signed-off-by: Marco Pagani <marpagan@redhat.com> > > I've submitted last week this patch: > https://lore.kernel.org/all/20240221125324.718192-1-mripard@kernel.org/ > > Which should be equivalent, but fixes the issue for all users in the > tree.
Hi, thanks for letting me know. Fixing this issue for all DRM tests that were using platform devices through the helpers makes perfect sense to me. I'm a little more thoughtful about setting the mask for all KUnit tests that use fake devices since there may be specific use cases. Just one curiosity: why setting the default mask manually instead of using one of the dma_set_*() functions?
Thanks, Marco
| |