Messages in this thread | | | Date | Mon, 26 Feb 2024 16:42:33 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v8 23/38] input: keypad: ep93xx: add DT support for Cirrus EP93xx |
| |
On Mon, Feb 26, 2024 at 10:30:19AM +0300, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin <nikita.shubin@maquefel.me> > > - drop flags, they were not used anyway > - add OF ID match table > - process "autorepeat", "debounce-delay-ms", prescale from device tree > - drop platform data usage and it's header > - keymap goes from device tree now on
..
> struct ep93xx_keypad { > - struct ep93xx_keypad_platform_data *pdata; > struct input_dev *input_dev; > struct clk *clk; > + unsigned int debounce; > + uint16_t prescale;
In case you need to send a new version note that the indentation of the fields is different here. Also uint16_t is not the type we expect to see usually (does the file use it already?). In kernel we have u16.
> void __iomem *mmio_base;
-- With Best Regards, Andy Shevchenko
| |