lkml.org 
[lkml]   [2024]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] dt-bindings: usb: add hisilicon,hi3798mv200-dwc3
From
On 24/02/2024 12:33, Yang Xiwen wrote:
> On 2/24/2024 6:28 PM, Krzysztof Kozlowski wrote:
>> On 23/02/2024 22:43, Yang Xiwen via B4 Relay wrote:
>>> From: Yang Xiwen <forbidden405@outlook.com>
>>>
>>> Document the DWC3 controller used by Hi3798MV200.
>>>
>>> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
>>
>>> +
>>> +properties:
>>> + compatible:
>>> + const: hisilicon,hi3798mv200-dwc3
>>> +
>>> + '#address-cells':
>>> + const: 1
>>> +
>>> + '#size-cells':
>>> + const: 1
>>> +
>>> + reg: true
>> Constraints. maxItems: X
>
>
> Is it mandatory to have this property if this node is going to be under
> a "simple-bus"? I'm taking rk3399-dwc3.yaml as reference. In fact, dwc3
> wrapper on mv200 does not have an extra register space. The wrapper only
> needs to turn on the clocks and deassert the resets. It does not
> need/have a register space.

Then why did you add it? No, the property is not mandatory. Write
bindings in a way they match hardware...

>
>
> I don't think it makes sense duplicating the same address twice.
>
>
> But reg property is required by "simple-bus" so i don't know why there
> is no warning for rk3399-dwc3.

I don't think it is. ranges or reg is.

Best regards,
Krzysztof


\
 
 \ /
  Last update: 2024-05-27 15:20    [W:0.263 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site