Messages in this thread | | | Subject | Re: [PATCH v5 5/5] iio: amplifiers: hmc425a: add support for LTC6373 Instrumentation Amplifier | From | Nuno Sá <> | Date | Wed, 21 Feb 2024 14:23:51 +0100 |
| |
On Tue, 2024-02-20 at 17:34 +0200, Dumitru Ceclan wrote: > This adds support for LTC6373 36 V Fully-Differential Programmable-Gain > Instrumentation Amplifier with 25 pA Input Bias Current. > The user can program the gain to one of seven available settings through > a 3-bit parallel interface (A2 to A0). > > Signed-off-by: Dumitru Ceclan <mitrutzceclan@gmail.com> > ---
Just one minor comment. With that:
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> drivers/iio/amplifiers/hmc425a.c | 124 ++++++++++++++++++++++++++++++- > 1 file changed, 120 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c > index 77872e2dfdfe..50c86c2d28d7 100644 > --- a/drivers/iio/amplifiers/hmc425a.c > +++ b/drivers/iio/amplifiers/hmc425a.c > @@ -2,9 +2,10 @@ > /* > * HMC425A and similar Gain Amplifiers > * > - * Copyright 2020 Analog Devices Inc. > + * Copyright 2020, 2024 Analog Devices Inc. > */
..
> > > +static ssize_t ltc6373_read_powerdown(struct iio_dev *indio_dev, > + uintptr_t private, > + const struct iio_chan_spec *chan, > + char *buf) > +{ > + struct hmc425a_state *st = iio_priv(indio_dev); > + > + return sysfs_emit(buf, "%d\n", st->powerdown);
Well, in theory the read should also be protected with the lock...
- Nuno Sá
| |