Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 21 Feb 2024 10:43:12 +0100 | Subject | Re: [PATCH] mmc: sh_mmcif: sg_miter does not need to be atomic |
| |
Hi Linus,
Thanks for your patch!
s/does not need to/must/?
On Tue, Feb 20, 2024 at 11:58 PM Linus Walleij <linus.walleij@linaro.org> wrote: > All the sglist iterations happen in the *threaded* interrupt handler > and that context is not atomic, so don't request an atomic > sglist miter. Using an atomic miter results in "BUG: scheduling while > atomic" splats. > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: 27b57277d9ba ("mmc: sh_mmcif: Use sg_miter for PIO") > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > Hi Geert, it'd be great if you could test this!
Thanks, that fixes the BUG, so Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Unfortunately it is not sufficient to make the eMMC work fully. I will follow up in the original thread...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |