lkml.org 
[lkml]   [2024]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] scsi: ufs: core: Fix mcq mac configuration
From


On 2/20/2024 5:56 PM, Rohit Ner wrote:
> As per JEDEC Standard No. 223E Section 5.9.2,
> the max # active commands value programmed by the host sw
> in MCQConfig.MAC should be one less than the actual value.
>
> Signed-off-by: Rohit Ner <rohitner@google.com>
> ---
> drivers/ufs/core/ufs-mcq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index 0787456c2b89..c873fd823942 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -94,7 +94,7 @@ void ufshcd_mcq_config_mac(struct ufs_hba *hba, u32 max_active_cmds)
>
> val = ufshcd_readl(hba, REG_UFS_MCQ_CFG);
> val &= ~MCQ_CFG_MAC_MASK;
> - val |= FIELD_PREP(MCQ_CFG_MAC_MASK, max_active_cmds);
> + val |= FIELD_PREP(MCQ_CFG_MAC_MASK, max_active_cmds - 1);
> ufshcd_writel(hba, val, REG_UFS_MCQ_CFG);
> }
> EXPORT_SYMBOL_GPL(ufshcd_mcq_config_mac);

Reviewed-by: Can Guo <quic_cang@quicinc.com>

\
 
 \ /
  Last update: 2024-05-27 15:14    [W:0.095 / U:1.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site