Messages in this thread | | | Date | Wed, 21 Feb 2024 15:50:55 +0800 | From | Hangbin Liu <> | Subject | Re: [PATCH net-next v5] bonding: rate-limit bonding driver inspect messages |
| |
On Wed, Feb 21, 2024 at 10:38:09AM +0530, Praveen Kumar Kannoju wrote: > Through the routine bond_mii_monitor(), bonding driver inspects and commits > the slave state changes. During the times when slave state change and > failure in aqcuiring rtnl lock happen at the same time, the routine > bond_mii_monitor() reschedules itself to come around after 1 msec to commit > the new state. > > During this, it executes the routine bond_miimon_inspect() to re-inspect > the state chane and prints the corresponding slave state on to the console. > Hence we do see a message at every 1 msec till the rtnl lock is acquired > and state chage is committed. > > This patch doesn't change how bond functions. It only simply limits this > kind of log flood. > > Signed-off-by: Praveen Kumar Kannoju <praveen.kannoju@oracle.com> > --- > v5: > - Redundant indentation addressed. > v4: https://lore.kernel.org/all/20240220050437.5623-1-praveen.kannoju@oracle.com/ > - Rectification in the patch subject and versioning details. > v3: https://lore.kernel.org/lkml/20240219133721.4567-1-praveen.kannoju@oracle.com/ > - Commit message is modified to provide summary of the issue, because of > which rate-limiting the bonding driver messages is needed. > v2: https://lore.kernel.org/lkml/20240215172554.4211-1-praveen.kannoju@oracle.com/ > - Use exising net_ratelimit() instead of introducing new rate-limit > parameter. > v1: https://lore.kernel.org/lkml/20240214044245.33170-1-praveen.kannoju@oracle.com/ > --- > drivers/net/bonding/bond_main.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 4e0600c..c8482cd 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -2609,12 +2609,12 @@ static int bond_miimon_inspect(struct bonding *bond) > bond_propose_link_state(slave, BOND_LINK_FAIL); > commit++; > slave->delay = bond->params.downdelay; > - if (slave->delay) { > + if (slave->delay && net_ratelimit()) { > slave_info(bond->dev, slave->dev, "link status down for %sinterface, disabling it in %d ms\n", > (BOND_MODE(bond) == > - BOND_MODE_ACTIVEBACKUP) ? > - (bond_is_active_slave(slave) ? > - "active " : "backup ") : "", > + BOND_MODE_ACTIVEBACKUP) ? > + (bond_is_active_slave(slave) ? > + "active " : "backup ") : "",
Why these lines changed?
Hangbin
| |