Messages in this thread | | | Date | Wed, 21 Feb 2024 20:06:41 -0600 | From | Bjorn Andersson <> | Subject | Re: [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration |
| |
On Sat, Feb 17, 2024 at 04:02:24PM +0100, Johan Hovold wrote: > diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c b/drivers/gpu/drm/bridge/aux-hpd-bridge.c [..] > +/** > + * devm_drm_dp_hpd_bridge_add - register a HDP DisplayPort bridge
kernel-doc wants () after function names.
> + * @dev: struct device to tie registration lifetime to > + * @adev: bridge auxiliary device to be registered > + * > + * Returns: zero on success or a negative errno
and "Return:" without the 's'.
This could however be done in a separate patch, as the file is already wrong in this regard.
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards, Bjorn
| |