lkml.org 
[lkml]   [2024]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 11/25] security: add hooks for set/get/remove of fscaps
    On Wed, Feb 21, 2024 at 4:26 PM Seth Forshee (DigitalOcean)
    <sforshee@kernel.org> wrote:
    >
    > In preparation for moving fscaps out of the xattr code paths, add new
    > security hooks. These hooks are largely needed because common kernel
    > code will pass around struct vfs_caps pointers, which EVM will need to
    > convert to raw xattr data for verification and updates of its hashes.
    >
    > Signed-off-by: Seth Forshee (DigitalOcean) <sforshee@kernel.org>
    > ---
    > include/linux/lsm_hook_defs.h | 7 +++++
    > include/linux/security.h | 33 +++++++++++++++++++++
    > security/security.c | 69 +++++++++++++++++++++++++++++++++++++++++++
    > 3 files changed, 109 insertions(+)

    One minor problem below, but assuming you fix that, this looks okay to me.

    Acked-by: Paul Moore <paul@paul-moore.com>

    > diff --git a/security/security.c b/security/security.c
    > index 3aaad75c9ce8..0d210da9862c 100644
    > --- a/security/security.c
    > +++ b/security/security.c
    > @@ -2351,6 +2351,75 @@ int security_inode_remove_acl(struct mnt_idmap *idmap,

    ..

    > +/**
    > + * security_inode_get_fscaps() - Check if reading fscaps is allowed
    > + * @dentry: file

    You are missing an entry for the @idmap parameter.

    > + * Check permission before getting fscaps.
    > + *
    > + * Return: Returns 0 if permission is granted.
    > + */
    > +int security_inode_get_fscaps(struct mnt_idmap *idmap, struct dentry *dentry)
    > +{
    > + if (unlikely(IS_PRIVATE(d_backing_inode(dentry))))
    > + return 0;
    > + return call_int_hook(inode_get_fscaps, 0, idmap, dentry);
    > +}

    --
    paul-moore.com

    \
     
     \ /
      Last update: 2024-05-27 15:15    [W:5.152 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site