lkml.org 
[lkml]   [2024]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/9] kunit: test: Log the correct filter string in executor_test
    Hi,

    On Wed, Feb 21, 2024 at 05:27:14PM +0800, David Gow wrote:
    > KUnit's executor_test logs the filter string in KUNIT_ASSERT_EQ_MSG(),
    > but passed a random character from the filter, rather than the whole
    > string.
    >
    > This was found by annotating KUNIT_ASSERT_EQ_MSG() to let gcc validate
    > the format string.
    >
    > Fixes: 76066f93f1df ("kunit: add tests for filtering attributes")
    > Signed-off-by: David Gow <davidgow@google.com>

    Reviewed-by: Justin Stitt <justinstitt@google.com>
    > ---
    > lib/kunit/executor_test.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/lib/kunit/executor_test.c b/lib/kunit/executor_test.c
    > index 22d4ee86dbed..3f7f967e3688 100644
    > --- a/lib/kunit/executor_test.c
    > +++ b/lib/kunit/executor_test.c
    > @@ -129,7 +129,7 @@ static void parse_filter_attr_test(struct kunit *test)
    > GFP_KERNEL);
    > for (j = 0; j < filter_count; j++) {
    > parsed_filters[j] = kunit_next_attr_filter(&filter, &err);
    > - KUNIT_ASSERT_EQ_MSG(test, err, 0, "failed to parse filter '%s'", filters[j]);
    > + KUNIT_ASSERT_EQ_MSG(test, err, 0, "failed to parse filter from '%s'", filters);
    > }
    >
    > KUNIT_EXPECT_STREQ(test, kunit_attr_filter_name(parsed_filters[0]), "speed");
    > --
    > 2.44.0.rc0.258.g7320e95886-goog
    >

    Thanks
    Justin

    \
     
     \ /
      Last update: 2024-05-27 15:15    [W:5.953 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site