Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH 02/30] thread_info: selector for TIF_NEED_RESCHED[_LAZY] | Date | Wed, 21 Feb 2024 21:03:59 +0100 |
| |
On Wed, Feb 21 2024 at 13:26, Steven Rostedt wrote: > On Mon, 12 Feb 2024 21:55:26 -0800 > Ankur Arora <ankur.a.arora@oracle.com> wrote: > >> +/* >> + * tif_resched(r) maps to TIF_NEED_RESCHED[_LAZY] with CONFIG_PREEMPT_AUTO. >> + * >> + * With !CONFIG_PREEMPT_AUTO, both tif_resched(NR_now) and tif_resched(NR_lazy) >> + * reduce to the same value (TIF_NEED_RESCHED) leaving any scheduling behaviour >> + * unchanged. >> + */ >> +static inline int tif_resched(resched_t rs) >> +{ >> + return TIF_NEED_RESCHED + rs * TIF_NEED_RESCHED_LAZY_OFFSET; >> +} >> + >> +static inline int _tif_resched(resched_t rs) >> +{ >> + return 1 << tif_resched(rs); >> +} >> + > > This may have been mentioned in another thread (don't remember) but please > make the above __always_inline, as that also matches tif_need_resched() as > it is today.
It's required as this is used in noinstr sections.
| |