Messages in this thread | | | Date | Wed, 21 Feb 2024 20:30:53 +0100 | Subject | Re: [PATCH] mm/mmu_gather: change __tlb_remove_tlb_entry() to an inline function | From | David Hildenbrand <> |
| |
On 21.02.24 16:45, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> >
Hi Arnd,
> clang complains about tlb_remove_tlb_entries() not using the 'ptep' variable > when __tlb_remove_tlb_entry() is an empty macro: > > include/asm-generic/tlb.h:627:10: error: parameter 'ptep' set but not used [-Werror,-Wunused-but-set-parameter] > > Change it to an equivalent inline function that avoids the warning since > the compiler can see how the variable gets passed into it. >
Ugh, quite an annoying clang behavior in this particular case. I wonder why no build bot complained so far.
Thanks!
> Fixes: 66958b447695 ("mm/mmu_gather: add tlb_remove_tlb_entries()")
That commit id is not stable yet. So Andrew might want to fold it into that commit before moving it to mm-stable.
-- Cheers,
David / dhildenb
| |