Messages in this thread | | | Date | Wed, 21 Feb 2024 16:53:44 +0100 | Subject | Re: [PATCH v2 2/5] nvme-fc: do not retry when auth fails or connection is refused | From | Hannes Reinecke <> |
| |
On 2/21/24 14:24, Daniel Wagner wrote: > There is no point in retrying to connect if the authentication fails. > > Connection refused is also issued from the authentication path, thus > also do not retry. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > drivers/nvme/host/fc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c > index a5b29e9ad342..b81046c9f171 100644 > --- a/drivers/nvme/host/fc.c > +++ b/drivers/nvme/host/fc.c > @@ -3312,6 +3312,8 @@ nvme_fc_reconnect_or_delete(struct nvme_fc_ctrl *ctrl, int status) > ctrl->cnum, status); > if (status > 0 && (status & NVME_SC_DNR)) > recon = false; > + if (status == NVME_SC_AUTH_REQUIRED || status == -ECONNREFUSED) > + recon = false; > } else if (time_after_eq(jiffies, rport->dev_loss_end)) > recon = false; > Is this still required after the patchset to retry authentication errors?
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
| |