Messages in this thread | | | Date | Fri, 2 Feb 2024 11:06:01 +0800 | Subject | Re: [PATCH net-next v4 08/11] stmmac: intel: configure SerDes according to the interface mode | From | Choong Yong Liang <> |
| |
On 31/1/2024 6:58 pm, Ilpo Järvinen wrote: > On Mon, 29 Jan 2024, Choong Yong Liang wrote: > >> From: "Tan, Tee Min" <tee.min.tan@linux.intel.com> >> >> Intel platform will configure the SerDes through PMC api based on the >> provided interface mode. >> >> This patch adds several new functions below:- >> - intel_tsn_interface_is_available(): This new function reads FIA lane >> ownership registers and common lane registers through IPC commands >> to know which lane the mGbE port is assigned to. >> - intel_config_serdes(): To configure the SerDes based on the assigned >> lane and latest interface mode, it sends IPC command to the PMC through >> PMC driver/API. The PMC acts as a proxy for R/W on behalf of the driver. >> - intel_set_reg_access(): Set the register access to the available TSN >> interface. >> >> Signed-off-by: Tan, Tee Min <tee.min.tan@linux.intel.com> >> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com> >> --- >> drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 + >> .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 113 +++++++++++++++++- >> .../net/ethernet/stmicro/stmmac/dwmac-intel.h | 75 ++++++++++++ >> 3 files changed, 188 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig >> index 85dcda51df05..be423fb2b46c 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig >> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig >> @@ -273,6 +273,7 @@ config DWMAC_INTEL >> default X86 >> depends on X86 && STMMAC_ETH && PCI >> depends on COMMON_CLK >> + select INTEL_PMC_IPC > > INTEL_PMC_IPC has depends on ACPI but selecting INTEL_PMC_IPC won't > enforce it AFAIK. > Hi Ilpo,
Thank you for pointing this out. I will check on my side too. Will fix it in the new patch series.
| |