Messages in this thread | | | Date | Fri, 2 Feb 2024 08:35:58 -0800 | Subject | Re: [RFC V1 5/5] x86: CVMs: Ensure that memory conversions happen at 2M alignment | From | Dave Hansen <> |
| |
On 2/2/24 08:22, Vishal Annapurve wrote: >> If you must - focus on getting swiotlb conversions to happen at the desired >> granularity but don't try to force every single conversion to be >4K. > If any conversion within a guest happens at 4K granularity, then this > will effectively cause non-hugepage aligned EPT/NPT entries. This > series is trying to get all private and shared memory regions to be > hugepage aligned to address the problem statement.
Yeah, but the series is trying to do that by being awfully myopic at this stage and without being _declared_ to be so myopic.
Take a look at all of the set_memory_decrypted() calls. How many of them even operate on the part of the guest address space rooted in the memfd where splits matter? They're not doing conversions. They're just setting up shared mappings in the page tables of gunk that was never private in the first place.
| |