Messages in this thread | | | From | Ian Rogers <> | Date | Fri, 2 Feb 2024 07:40:12 -0800 | Subject | Re: [PATCH 1/1] perf bpf: Clean up the generated/copied vmlinux.h |
| |
On Fri, Feb 2, 2024 at 6:32 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > When building perf with BPF skels we either copy the minimalistic > tools/perf/util/bpf_skel/vmlinux/vmlinux.h or use bpftool to generate a > vmlinux from BTF, storing the result in $(SKEL_OUT)/vmlinux.h. > > We need to remove that when doing a 'make -C tools/perf clean', fix it. > > Fixes: b7a2d774c9c5a9a3 ("perf build: Add ability to build with a generated vmlinux.h") > Cc: Adrian Hunter <adrian.hunter@intel.com> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> > Cc: Andrii Nakryiko <andrii@kernel.org> > Cc: bpf@vger.kernel.org > Cc: Ian Rogers <irogers@google.com> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: James Clark <james.clark@arm.com> > Cc: Jiri Olsa <jolsa@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Tiezhu Yang <yangtiezhu@loongson.cn> > Cc: Yang Jihong <yangjihong1@huawei.com> > Link: https://lore.kernel.org/lkml/ > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, Ian
> --- > tools/perf/Makefile.perf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 27e7c478880fdecd..51ac396ed9f641af 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -1157,7 +1157,7 @@ bpf-skel: > endif # CONFIG_PERF_BPF_SKEL > > bpf-skel-clean: > - $(call QUIET_CLEAN, bpf-skel) $(RM) -r $(SKEL_TMP_OUT) $(SKELETONS) > + $(call QUIET_CLEAN, bpf-skel) $(RM) -r $(SKEL_TMP_OUT) $(SKELETONS) $(SKEL_OUT)/vmlinux.h > > clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $(LIBPERF)-clean arm64-sysreg-defs-clean fixdep-clean python-clean bpf-skel-clean tests-coresight-targets-clean > $(call QUIET_CLEAN, core-objs) $(RM) $(LIBPERF_A) $(OUTPUT)perf-archive $(OUTPUT)perf-iostat $(LANG_BINDINGS) > -- > 2.43.0 >
| |