Messages in this thread | | | Date | Fri, 2 Feb 2024 21:16:02 +0300 | Subject | Re: [PATCH net-next v3 4/7] net: dsa: mt7530: move XTAL check to mt7530_setup() | From | Arınç ÜNAL <> |
| |
On 2.02.2024 14:48, Russell King (Oracle) wrote: > On Fri, Feb 02, 2024 at 12:19:10PM +0300, Arınç ÜNAL via B4 Relay wrote: >> From: Arınç ÜNAL <arinc.unal@arinc9.com> >> >> The crystal frequency concerns the switch core. The frequency should be >> checked when the switch is being set up so the driver can reject the >> unsupported hardware earlier and without requiring port 6 to be used. >> >> Move it to mt7530_setup(). Drop the unnecessary function printing. >> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >> Reviewed-by: Andrew Lunn <andrew@lunn.ch> >> Reviewed-by: Vladimir Oltean <olteanv@gmail.com> > > I would prefer this to be earlier in the series, before patch 2 which > moves mt7530_setup_port6() to be called from mac_config(). mac_config() > is supposed to be configuration error-free - in other words, all state > should have been checked before hand.
I agree but mt7530_mac_config() is not a void function yet. The mac_port_config member of the mt753x_info structure points to this function. My next patch series gets rid of all useless error returns on the phylink path and change mac_port_config to void. So I don't think working on this patch series further will worth the effort. I'd rather have this version applied as is.
Arınç
| |