Messages in this thread | | | From | Miguel Ojeda <> | Date | Mon, 19 Feb 2024 17:00:49 +0100 | Subject | Re: [PATCH] rust: upgrade to Rust 1.77.0 |
| |
On Mon, Feb 19, 2024 at 10:06 AM Alice Ryhl <aliceryhl@google.com> wrote: > > Maybe you should just add the as_ptr method to ThisModule now? It will > silence the warning, and doesn't trigger a warning of its own since it > is pub.
Yeah, either way is fine -- I meant the patch to be independent and to avoid adding an API without a user, but it is not a big deal.
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Thanks!
Cheers, Miguel
| |