Messages in this thread | | | Date | Mon, 19 Feb 2024 16:35:23 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH printk v2 08/26] printk: nbcon: Implement processing in port->lock wrapper |
| |
On Mon, Feb 19, 2024 at 03:24:47PM +0106, John Ogness wrote: > On 2024-02-19, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
..
> >> #include <linux/console.h> > >> #include <linux/delay.h> > >> #include <linux/slab.h> > >> +#include <linux/serial_core.h> > > > > The headers in this file is a mess. But here you can at least keep the > > piece ordered, can you? > > Just to clarify, you would like to see this ordering and inclusion?
Roughly, yes. Ideally it is quite likely that kernel.h is being used as a 'proxy' header. Nowadays, it's rare the code needs kernel.h.
> #include <linux/bug.h> > #include <linux/console.h> > #include <linux/delay.h> > #include <linux/export.h> > #include <linux/kernel.h> > #include <linux/serial_core.h> > #include <linux/slab.h> > #include <linux/string.h>
-- With Best Regards, Andy Shevchenko
| |