Messages in this thread | | | Date | Mon, 19 Feb 2024 10:23:49 +0100 | Subject | Re: [PATCH v2 1/2] dt-bindings: arm64: mediatek: add Kontron 3.5"-SBC-i1200 | From | AngeloGioacchino Del Regno <> |
| |
Il 19/02/24 09:44, Michael Walle ha scritto: > Add the compatible string for the Kontron 3.5"-SBC-i1200 single board > computer. > > Signed-off-by: Michael Walle <mwalle@kernel.org> > --- > v2: > - convert enum to const as there is only one specific board > > Documentation/devicetree/bindings/arm/mediatek.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 09f9ffd3ff7b..add167d8b8da 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -357,6 +357,11 @@ properties: > - radxa,nio-12l > - const: mediatek,mt8395 > - const: mediatek,mt8195 > + - description: Kontron 3.5"-SBC-i1200 > + items: > + - const: kontron,3-5-sbc-i1200 > + - const: mediatek,mt8395 > + - const: mediatek,mt8195 > - items: > - enum: > - mediatek,mt8516-pumpkin
I understand that you took inspiration from the Google Chromebooks entries, but those are separated only because they've got "a bunch of revisions".
For machines that don't have a billion compatible strings, I would suggest to add the compatible under a single big entry: like this, the binding is (imo) a bit more readable .. and cleaner.
Eventually, the machine name is in the devicetree so we're not losing any kind of information anyway... :-)
- items: - enum: - kontron,3-5-sbc-i1200 - mediatek,mt8395-evk - radxa,nio-12l - const: mediatek,mt8395 - const: mediatek,mt8195
Cheers, Angelo
| |