Messages in this thread | | | Date | Mon, 19 Feb 2024 11:44:08 -0700 | From | Keith Busch <> | Subject | Re: [PATCH v1 1/6] nvme-fabrics: introduce connect_sync option |
| |
On Mon, Feb 19, 2024 at 02:15:26PM +0100, Daniel Wagner wrote: > The TCP and RDMA transport are doing a synchronous connect, meaning the > syscal returns with the final result, that is. it either failed or > succeeded. > > This isn't the case for FC. This transport just setups and triggers > the connect and returns without waiting on the result. Introduce a flag > to allow user space to control the behavior, wait or don't wait.
The series looks good to me. My only feedback is this patch doesn't change anything without patch 6, so I think these two go together.
| |