Messages in this thread | | | From | Alex Deucher <> | Date | Fri, 16 Feb 2024 11:59:42 -0500 | Subject | Re: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2 |
| |
Applied. Thanks.
Alex
On Fri, Feb 16, 2024 at 5:38 AM Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote: > > On Thu, 15 Feb 2024, Deucher, Alexander wrote: > > > [Public] > > > > > -----Original Message----- > > > From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > > Sent: Thursday, February 15, 2024 8:32 AM > > > To: Deucher, Alexander <Alexander.Deucher@amd.com>; amd- > > > gfx@lists.freedesktop.org; Daniel Vetter <daniel@ffwll.ch>; David Airlie > > > <airlied@gmail.com>; Dennis Dalessandro > > > <dennis.dalessandro@cornelisnetworks.com>; dri- > > > devel@lists.freedesktop.org; Jason Gunthorpe <jgg@ziepe.ca>; Leon > > > Romanovsky <leon@kernel.org>; linux-kernel@vger.kernel.org; linux- > > > rdma@vger.kernel.org; Pan, Xinhui <Xinhui.Pan@amd.com>; Koenig, Christian > > > <Christian.Koenig@amd.com> > > > Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>; Lukas Wunner > > > <lukas@wunner.de> > > > Subject: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2 > > > > > > Convert open coded RMW accesses for LNKCTL2 to use > > > pcie_capability_clear_and_set_word() which makes its easier to understand > > > what the code tries to do. > > > > > > LNKCTL2 is not really owned by any driver because it is a collection of control > > > bits that PCI core might need to touch. RMW accessors already have support > > > for proper locking for a selected set of registers > > > (LNKCTL2 is not yet among them but likely will be in the future) to avoid losing > > > concurrent updates. > > > > > > Suggested-by: Lukas Wunner <lukas@wunner.de> > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > > > The radeon and amdgpu patches are: > > Acked-by: Alex Deucher <alexander.deucher@amd.com> > > > > Are you looking for me to pick them up or do you want to land them as > > part of some larger change? Either way is fine with me. > > Hi, > > You please take them, I intentionally took them apart from the BW > controller series so they can go through the usual trees, not along with > the BW controller. (I don't expect the BW controller to be accepted during > this cycle). > > -- > i.
| |