Messages in this thread | | | Date | Fri, 16 Feb 2024 17:23:48 +0100 | Subject | Re: [PATCH v5] sparc: vDSO: fix return value of __setup handler | From | Andreas Larsson <> |
| |
On 2024-02-11 06:28, Randy Dunlap wrote: > __setup() handlers should return 1 to obsolete_checksetup() in > init/main.c to indicate that the boot option has been handled. > A return of 0 causes the boot option/value to be listed as an Unknown > kernel parameter and added to init's (limited) argument or environment > strings. Also, error return codes don't mean anything to > obsolete_checksetup() -- only non-zero (usually 1) or zero. > So return 1 from vdso_setup(). > > Fixes: 9a08862a5d2e ("vDSO for sparc") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: Igor Zhbanov <izh1979@gmail.com> > Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru > Cc: "David S. Miller" <davem@davemloft.net> > Cc: sparclinux@vger.kernel.org > Cc: Dan Carpenter <dan.carpenter@oracle.com> > Cc: Nick Alcock <nick.alcock@oracle.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: stable@vger.kernel.org > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Andreas Larsson <andreas@gaisler.com>
Applied to my for-next branch.
Thanks, Andreas
| |