Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 16 Feb 2024 15:11:09 +0100 | Subject | Re: [PATCH 13/17] arm64: dts: renesas: r9a07g043: Update #power-domain-cells = <1> |
| |
Hi Claudiu,
On Thu, Feb 8, 2024 at 1:44 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Update CPG #power-domain-cells = <1> and move all the IPs to be part of the > always on power domain as the driver has been modified to support multiple > power domains. > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi > @@ -138,7 +138,7 @@ mtu3: timer@10001200 { > "tgia8", "tgib8", "tgic8", "tgid8", > "tciv8", "tciu8"; > clocks = <&cpg CPG_MOD R9A07G043_MTU_X_MCK_MTU3>; > - power-domains = <&cpg>; > + power-domains = <&cpg R9A07G043_PD_ALWAYS_ON>;
This should be R9A07G043_PD_MTU, but that domain is not yet supported by the driver. Instead of adding incorrect hardware descriptions, I'd rather defer this until all domains are handled by the driver.
> resets = <&cpg R9A07G043_MTU_X_PRESET_MTU3>; > #pwm-cells = <2>; > status = "disabled";
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |