Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 16 Feb 2024 15:04:52 +0100 | Subject | Re: [PATCH 06/17] dt-bindings: clock: renesas,rzg2l-cpg: Update #power-domain-cells = <1> |
| |
Hi Claudiu,
On Thu, Feb 8, 2024 at 1:43 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > The driver will be modified (in the next commits) to be able to specify > individual power domain ID for each IP. Update the documentation to cope > with this. > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml > +++ b/Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml > @@ -57,7 +57,7 @@ properties: > can be power-managed through Module Standby should refer to the CPG device > node in their "power-domains" property, as documented by the generic PM > Domain bindings in Documentation/devicetree/bindings/power/power-domain.yaml. > - const: 0 > + const: 1
While the driver will soon support both 0 and 1, we may need to keep 0 for RZ/V2M for now? RZ/V2M does not have CPG_BUS_*_MSTOP registers, but uses the Internal Power Domain Controller (PMC).
Please add a link to the power domain numbers in <dt-bindings/clock/r9a0*-cpg.h>, like is done for #clock-cells.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |