Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH] arch/x86/entry_fred: don't set up KVM IRQs if KVM is disabled | Date | Fri, 16 Feb 2024 23:29:06 +0100 |
| |
On Fri, Feb 16 2024 at 22:46, Borislav Petkov wrote: > On Fri, Feb 16, 2024 at 07:31:46AM +0100, Paolo Bonzini wrote: >> and it seems to be a net improvement to me. The #ifs match in >> the .h and .c files, and there are no unnecessary initializers >> in the sysvec_table. > > Ok, I'll pick up Max' patch tomorrow and we must remember to tell Linus > during the merge window about this.
No. Don't.
This pointless #ifdeffery in the vector header needs to vanish from the KVM tree.
Why would you take the #ifdef mess into tasteful code just because someone decided that #ifdeffing out constants in a header which is maintained by other people is a brilliant idea?
The #ifdeffery in the idtentry header is unavoidable and the extra NULL defines are at the right place and not making the actual code unreadable.
Thanks,
tglx
| |